Bug 193819

Summary: Use ENABLE_POINTER_EVENTS for the touch-action property
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

Description Antoine Quint 2019-01-25 02:41:46 PST
Use ENABLE_POINTER_EVENTS for the touch-action property
Comment 1 Antoine Quint 2019-01-25 02:42:42 PST
Created attachment 360095 [details]
Patch
Comment 2 Antti Koivisto 2019-01-25 02:48:57 PST
Comment on attachment 360095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360095&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1750
> -#if ENABLE(TOUCH_EVENTS)
> +#if ENABLE(POINTER_EVENTS)

You should also remove the flag from the configuration files.
Comment 3 Antoine Quint 2019-01-25 02:53:15 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 360095 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=360095&action=review
> 
> > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1750
> > -#if ENABLE(TOUCH_EVENTS)
> > +#if ENABLE(POINTER_EVENTS)
> 
> You should also remove the flag from the configuration files.

The TOUCH_EVENTS flag is still used for other purposes besides the touch-action property.
Comment 4 Antoine Quint 2019-01-25 03:37:06 PST
Committed r240472: <https://trac.webkit.org/changeset/240472>
Comment 5 Radar WebKit Bug Importer 2019-01-25 03:41:08 PST
<rdar://problem/47545777>