Bug 193738

Summary: Try to fix imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011.xht
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Michael Catanzaro <mcatanzaro>
Status: NEW    
Severity: Normal CC: cgarcia, lforschler, mcatanzaro, Ms2ger
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193628
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2019-01-23 14:17:09 PST
Try to fix imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011.xht. This reftest is failing for GTK since we switched to complex text because the "PASS" printed by the -expected.html now uses kerning.
Attachments
Patch (1.62 KB, patch)
2019-01-23 14:18 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2019-01-23 18:47 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-01-23 14:18:30 PST
(Let's see what Mac EWS thinks.)
Michael Catanzaro
Comment 2 2019-01-23 14:18:40 PST
Created attachment 359940 [details] Patch
Michael Catanzaro
Comment 3 2019-01-23 18:47:46 PST
Created attachment 359984 [details] Patch
Ms2ger (he/him; ⌚ UTC+1/+2)
Comment 4 2019-01-24 03:19:06 PST
Comment on attachment 359984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359984&action=review > LayoutTests/imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011-expected.html:9 > + <div style="font-kerning: none;">PASS</div> This is imported from `wpt/css/reference/pass_if_pass_below.html` upstream, so making this change there would affect a couple dozen other tests as well, unfortunately. OTOH, it seems like this is the only test with this reference that's imported in WebKit, so it's worth checking if they all fail without this change.
Michael Catanzaro
Comment 5 2019-01-24 09:00:36 PST
Hm, what's the easiest way to test it? Create an upstream pull request and see what happens on the upstream CI?
Michael Catanzaro
Comment 6 2019-05-06 19:04:20 PDT
Comment on attachment 359984 [details] Patch Removing this from my request queue, since I don't plan to work on this further.
Note You need to log in before you can comment on or make changes to this bug.