Bug 193725

Summary: Deprecate API to limit the maximum number of WebProcesses
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, berto, cgarcia, commit-queue, ews-watchlist, ggaren, gns, jeffm, mcatanzaro, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews104 for mac-highsierra-wk2
none
Patch
none
Patch none

Description Chris Dumez 2019-01-23 10:02:41 PST
Deprecate API to limit the maximum number of WebProcesses. This limit is no longer enforced with PSON enabled and is unsafe.
Comment 1 Chris Dumez 2019-01-23 10:02:57 PST
<rdar://problem/47464879>
Comment 2 Chris Dumez 2019-01-23 10:22:50 PST
Created attachment 359902 [details]
Patch
Comment 3 Chris Dumez 2019-01-23 11:50:14 PST
Created attachment 359917 [details]
Patch
Comment 4 EWS Watchlist 2019-01-23 11:53:07 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 EWS Watchlist 2019-01-23 14:17:01 PST
Comment on attachment 359917 [details]
Patch

Attachment 359917 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10862904

New failing tests:
imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html
Comment 6 EWS Watchlist 2019-01-23 14:17:03 PST
Created attachment 359939 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 Geoffrey Garen 2019-01-23 14:25:19 PST
It’s still useful to set the process limit to exactly 1, to make some kinds of debugging easier, so that you don’t need to reattach the debugger to each new process. Can we keep that working?
Comment 8 Chris Dumez 2019-01-23 14:57:36 PST
Created attachment 359946 [details]
Patch
Comment 9 Geoffrey Garen 2019-01-23 14:59:07 PST
Comment on attachment 359946 [details]
Patch

r=me
Comment 10 Chris Dumez 2019-01-23 15:28:19 PST
Created attachment 359956 [details]
Patch
Comment 11 Chris Dumez 2019-01-23 15:34:27 PST
Comment on attachment 359956 [details]
Patch

Clearing flags on attachment: 359956

Committed r240363: <https://trac.webkit.org/changeset/240363>
Comment 12 Chris Dumez 2019-01-23 15:34:29 PST
All reviewed patches have been landed.  Closing bug.