Bug 193725

Summary:

Deprecate API to limit the maximum number of WebProcesses

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, berto, cgarcia, commit-queue, ews-watchlist, ggaren, gustavo, jeffm, mcatanzaro, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-01-23 10:02:41 PST

Deprecate API to limit the maximum number of WebProcesses. This limit is no longer enforced with PSON enabled and is unsafe.

Attachments
Patch (29.48 KB, patch) 2019-01-23 10:22 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (31.10 KB, patch) 2019-01-23 11:50 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.73 MB, application/zip) 2019-01-23 14:17 PST, EWS Watchlist	no flags	Details
Patch (27.81 KB, patch) 2019-01-23 14:57 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (28.65 KB, patch) 2019-01-23 15:28 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-01-23 10:02:57 PST

<rdar://problem/47464879>

Chris Dumez

Comment 2 2019-01-23 10:22:50 PST

Created attachment 359902 [details] Patch

Chris Dumez

Comment 3 2019-01-23 11:50:14 PST

Created attachment 359917 [details] Patch

EWS Watchlist

Comment 4 2019-01-23 11:53:07 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

EWS Watchlist

Comment 5 2019-01-23 14:17:01 PST

Comment on attachment 359917 [details] Patch Attachment 359917 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10862904 New failing tests: imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-010.html

EWS Watchlist

Comment 6 2019-01-23 14:17:03 PST

Created attachment 359939 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Geoffrey Garen

Comment 7 2019-01-23 14:25:19 PST

It’s still useful to set the process limit to exactly 1, to make some kinds of debugging easier, so that you don’t need to reattach the debugger to each new process. Can we keep that working?

Chris Dumez

Comment 8 2019-01-23 14:57:36 PST

Created attachment 359946 [details] Patch

Geoffrey Garen

Comment 9 2019-01-23 14:59:07 PST

Comment on attachment 359946 [details] Patch r=me

Chris Dumez

Comment 10 2019-01-23 15:28:19 PST

Created attachment 359956 [details] Patch

Chris Dumez

Comment 11 2019-01-23 15:34:27 PST

Comment on attachment 359956 [details] Patch Clearing flags on attachment: 359956 Committed r240363: <https://trac.webkit.org/changeset/240363>

Chris Dumez

Comment 12 2019-01-23 15:34:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.