Summary: | [GTK] Crash when browsing inspector:// uri without port set | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | WebKitGTK | Assignee: | Philippe Normand <pnormand> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2019-01-23 08:08:54 PST
Created attachment 359887 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 359887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359887&action=review > Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:95 > GUniquePtr<GError> error(g_error_new_literal(WEBKIT_POLICY_ERROR, WEBKIT_POLICY_ERROR_CANNOT_SHOW_URI, "Cannot show inspector URL: no port provided")); > webkit_uri_scheme_request_finish_error(request, error.get()); > + return; D: Comment on attachment 359887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359887&action=review >> Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:95 >> + return; > > D: Oops. |