Bug 193717

Summary:

Add CSS Logical spec to features.json

Product:

WebKit

Reporter:

Oriol Brufau <obrufau>

Component:

WebCore Misc.

Assignee:

Oriol Brufau <obrufau>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, joepeck, rego, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-highsierra-wk2	none
Patch	none

Oriol Brufau

Reported 2019-01-23 07:29:08 PST

https://drafts.csswg.org/css-logical/ should be added into features.json

Attachments
Patch (1.35 KB, patch) 2019-01-23 07:31 PST, Oriol Brufau	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.76 MB, application/zip) 2019-01-23 08:47 PST, EWS Watchlist	no flags	Details
Patch (1.47 KB, patch) 2019-01-23 12:28 PST, Oriol Brufau	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oriol Brufau

Comment 1 2019-01-23 07:31:31 PST

Created attachment 359880 [details] Patch

EWS Watchlist

Comment 2 2019-01-23 08:47:15 PST

Comment on attachment 359880 [details] Patch Attachment 359880 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10858598 New failing tests: imported/w3c/web-platform-tests/css/css-grid/abspos/orthogonal-positioned-grid-descendants-015.html

EWS Watchlist

Comment 3 2019-01-23 08:47:16 PST

Created attachment 359892 [details] Archive of layout-test-results from ews107 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Manuel Rego Casasnovas

Comment 4 2019-01-23 12:15:50 PST

Comment on attachment 359880 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359880&action=review r=me > Source/WebCore/features.json:135 > + "category": "css" Please add your contact information. :-)

Oriol Brufau

Comment 5 2019-01-23 12:28:03 PST

Created attachment 359923 [details] Patch

WebKit Commit Bot

Comment 6 2019-01-23 12:54:36 PST

Comment on attachment 359923 [details] Patch Clearing flags on attachment: 359923 Committed r240354: <https://trac.webkit.org/changeset/240354>

WebKit Commit Bot

Comment 7 2019-01-23 12:54:38 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-01-23 12:55:45 PST

<rdar://problem/47490725>

Note You need to log in before you can comment on or make changes to this bug.