Bug 193710

Summary: [SOUP] Remove libsoup cruft from WebProcess
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2019-01-22 22:02:12 PST
SoupNetworkSession is no longer accessible from the web process because it's owned (indirectly) by NetworkProcess after r240292. It doesn't make sense to have any libsoup code under WebProcess anymore. The current libsoup code consists of: * Unused stuff to be removed * Stuff unrelated to libsoup, which should move to a WebProcessGLib.cpp * WebKitSoupRequestInputStream, which is only used by NetworkProcess and should move there
Attachments
Patch (34.06 KB, patch)
2019-01-22 22:05 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-01-22 22:05:35 PST
Created attachment 359855 [details] Patch
WebKit Commit Bot
Comment 2 2019-01-23 09:26:56 PST
Comment on attachment 359855 [details] Patch Clearing flags on attachment: 359855 Committed r240341: <https://trac.webkit.org/changeset/240341>
WebKit Commit Bot
Comment 3 2019-01-23 09:26:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.