Bug 193698

Summary: Clean up USE(WEB_THREAD)
Product: WebKit Reporter: Conrad Shultz <conrad_shultz>
Component: New BugsAssignee: Conrad Shultz <conrad_shultz>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap, bdakin, ews-watchlist, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Conrad Shultz
Reported 2019-01-22 16:53:12 PST
We do not apply USE(WEB_THREAD) consistently. It would be good to audit all uses of the web thread and patch up relevant sites.
Attachments
Patch (51.14 KB, patch)
2019-01-22 22:52 PST, Conrad Shultz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Conrad Shultz
Comment 1 2019-01-22 16:53:47 PST
<rdar://problem/47366779>
Conrad Shultz
Comment 2 2019-01-22 22:52:11 PST
Created attachment 359858 [details] Patch
EWS Watchlist
Comment 3 2019-01-22 22:55:22 PST
Attachment 359858 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/ios/WebCoreSupport/WebFixedPositionContent.mm:173: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4 2019-01-23 12:28:06 PST
Comment on attachment 359858 [details] Patch ears=me
Conrad Shultz
Comment 5 2019-01-23 12:30:38 PST
The style issue is tracked by "check-webkit-style false positive for [readability/parameter_name] with declaration inside if expression." (https://bugs.webkit.org/show_bug.cgi?id=174485)
Conrad Shultz
Comment 6 2019-01-23 12:37:18 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp M Source/WebCore/platform/cf/MainThreadSharedTimerCF.cpp M Source/WebCore/platform/cocoa/ContentFilterUnblockHandlerCocoa.mm M Source/WebCore/platform/graphics/cocoa/TextTrackRepresentationCocoa.mm M Source/WebCore/platform/ios/wak/WAKWindow.mm M Source/WebCore/platform/ios/LegacyTileCache.mm M Source/WebCore/platform/ios/WebCoreMotionManager.mm M Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm M Source/WebCore/platform/network/ios/NetworkStateNotifierIOS.mm M Source/WebCore/rendering/RenderThemeIOS.mm M Source/WebCore/ChangeLog M Source/WebKitLegacy/ios/Misc/WebGeolocationProviderIOS.mm M Source/WebKitLegacy/ios/WebCoreSupport/WebFixedPositionContent.mm M Source/WebKitLegacy/ios/ChangeLog M Source/WebKitLegacy/mac/Misc/WebCache.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/mac/ChangeLog r240353 = 24ba8bb9e1dad8679b492d9a2d47da619be85789 (refs/remotes/origin/master)
Simon Fraser (smfr)
Comment 7 2019-01-23 12:39:33 PST
I don't like the #ifdeffing of control flow here. Can't we make WebThreadRun just execute the block synchronously?
Conrad Shultz
Comment 8 2019-01-23 13:04:06 PST
(In reply to Simon Fraser (smfr) from comment #7) > I don't like the #ifdeffing of control flow here. Can't we make WebThreadRun > just execute the block synchronously? Understood. Per discussion, rolled out the change in r240355.
Note You need to log in before you can comment on or make changes to this bug.