Summary: | Regression(r240178) Some API tests are crashing | ||
---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ews-watchlist, ggaren, rniwa, ryanhaddad, tsavell, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 193588 | ||
Attachments: |
Description
Chris Dumez
2019-01-22 13:18:51 PST
Created attachment 359769 [details]
Patch
Attachment 359769 [details] did not pass style-queue:
ERROR: Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:321: More than one command on the same line [whitespace/newline] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 359769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359769&action=review > Source/WebKit/WebProcess/UserContent/WebUserContentController.h:125 > + typedef HashMap<RefPtr<InjectedBundleScriptWorld>, Vector<std::pair<uint64_t, RefPtr<WebUserMessageHandlerDescriptorProxy>>>> WorldToUserMessageHandlerVectorMap; I think it would be nice to give this pair's first and second members better names and name uint64_t. Comment on attachment 359769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359769&action=review >> Source/WebKit/WebProcess/UserContent/WebUserContentController.h:125 >> + typedef HashMap<RefPtr<InjectedBundleScriptWorld>, Vector<std::pair<uint64_t, RefPtr<WebUserMessageHandlerDescriptorProxy>>>> WorldToUserMessageHandlerVectorMap; > > I think it would be nice to give this pair's first and second members better names and name uint64_t. This is the pattern in this file. I don't mind cleaning things up but I'd rather do it in a follow-up to keep the patch as small as possible for cherry-picking. WDYT? Failures look legit, I'll investigate. Comment on attachment 359769 [details] Patch Attachment 359769 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10844579 New failing tests: userscripts/user-script-audio-document.html userscripts/user-script-image-document.html userscripts/user-script-video-document.html fast/media/use-system-appearance-user-stylesheet-parsing.html userscripts/user-script-plugin-document.html Created attachment 359776 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 359769 [details] Patch Attachment 359769 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10844534 New failing tests: userscripts/user-script-audio-document.html userscripts/user-script-image-document.html userscripts/user-script-video-document.html fast/media/use-system-appearance-user-stylesheet-parsing.html Created attachment 359782 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 359793 [details]
Patch
Attachment 359793 [details] did not pass style-queue:
ERROR: Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:321: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:388: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit/WebProcess/UserContent/WebUserContentController.cpp:437: More than one command on the same line [whitespace/newline] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 359793 [details] Patch Attachment 359793 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10847721 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 359818 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 359793 [details] Patch Clearing flags on attachment: 359793 Committed r240325: <https://trac.webkit.org/changeset/240325> All reviewed patches have been landed. Closing bug. |