Summary: | Plugins are drawn over the scrollbars | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pierre-Luc Beaudoin <pierre-luc.beaudoin> | ||||
Component: | WebKit Qt | Assignee: | marcoil <marc.ordinasillopis> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, siraj, tonikitoo | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
URL: | http://www.radio-canada.ca/nouvelles/ | ||||||
Attachments: |
|
Description
Pierre-Luc Beaudoin
2008-06-02 20:54:34 PDT
Created attachment 21643 [details] Fixes the bug for r34498 This patch fixes the issue clipping the embedded plugin window. Comment on attachment 21643 [details] Fixes the bug for r34498 Nice trick :), looks good to me. Reopening the bug as it's still present when the plugin is a native QWidget. I think there's two ways we could go fixing this: 1) Move the clipping handling up to WidgetQt. In this case we could also get rid of PluginView::m_window, as it's just a copy of WidgetPrivate::m_widget. 2) Move the native QWidget plugin support down from WidgetQt to PluginView. Now that we have NPAPI plugin support we could also move it all to an external plugin. Opinions? Comment on attachment 21643 [details] Fixes the bug for r34498 Clearing review since the patch was landed. |