Bug 193647

Summary: Dynamic changes in the style attributes of an SVGElement do no affect the <use> instances
Product: WebKit Reporter: kari.pihkala
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, rniwa, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
Patch
none
Archive of layout-test-results from ews101 for mac-highsierra
none
Archive of layout-test-results from ews114 for mac-highsierra
none
Patch none

kari.pihkala
Reported 2019-01-21 00:34:29 PST
Created attachment 359675 [details] test case SVG symbols are not repainted correctly if an element inside them has its stroke or fill style changed by JavaScript setTimeout() or requestAnimationFrame(). See the attached test case, which shows a rectangle outside and inside a symbol. The rectangle inside the symbol doesn't show changes in the fill style. However, changing the x or y property seem to force a repaint for the entire symbol. So, setting the "x" attribute of the rectangle makes also the fill style visible. Tested on Safari 10, 12.0.2 (14606.3.4) and Safari Technology Preview Release 73 (Safari 12.1, WebKit 14607.1.18.3). The test case works as expected on Firefox and Chrome. Here's the same test case as a CodePen: https://codepen.io/anon/pen/ZwzebM?editors=1000
Attachments
test case (980 bytes, image/svg+xml)
2019-01-21 00:34 PST, kari.pihkala 		no flags
Details
Patch (4.19 KB, patch)
2019-01-22 12:48 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-highsierra (2.79 MB, application/zip)
2019-01-22 13:41 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews114 for mac-highsierra (2.07 MB, application/zip)
2019-01-22 14:28 PST, EWS Watchlist 		no flags
Details
Patch (4.27 KB, patch)
2019-01-22 14:47 PST, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-22 08:32:27 PST
<rdar://problem/47446843>
Said Abou-Hallawa
Comment 2 2019-01-22 12:48:21 PST
Created attachment 359766 [details] Patch
EWS Watchlist
Comment 3 2019-01-22 13:41:20 PST
Comment on attachment 359766 [details] Patch Attachment 359766 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10843999 New failing tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg
EWS Watchlist
Comment 4 2019-01-22 13:41:21 PST
Created attachment 359770 [details] Archive of layout-test-results from ews101 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 5 2019-01-22 14:28:08 PST
Comment on attachment 359766 [details] Patch Attachment 359766 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10844242 New failing tests: svg/custom/svg-use-style-dynamic-change-invalidate.svg
EWS Watchlist
Comment 6 2019-01-22 14:28:09 PST
Created attachment 359773 [details] Archive of layout-test-results from ews114 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-highsierra Platform: Mac OS X 10.13.6
Said Abou-Hallawa
Comment 7 2019-01-22 14:47:20 PST
Created attachment 359778 [details] Patch
WebKit Commit Bot
Comment 8 2019-01-22 16:13:48 PST
Comment on attachment 359778 [details] Patch Clearing flags on attachment: 359778 Committed r240305: <https://trac.webkit.org/changeset/240305>
WebKit Commit Bot
Comment 9 2019-01-22 16:13:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.