Bug 193645

Summary: Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: MediaAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, eric.carlson, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-01-20 23:02:33 PST
Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}. This gets rid of 1 instance of duplicate soft-linking code for VideoToolbox.framework, and improves check-webkit-style to remind patch authors about other frameworks that have *SoftLink.{cpp,h,mm} files.
Attachments
Patch v1 (13.07 KB, patch)
2019-01-20 23:17 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-01-20 23:03:37 PST
<rdar://problem/47421574>
David Kilzer (:ddkilzer)
Comment 2 2019-01-20 23:17:19 PST
Created attachment 359671 [details] Patch v1
WebKit Commit Bot
Comment 3 2019-01-21 09:22:42 PST
Comment on attachment 359671 [details] Patch v1 Clearing flags on attachment: 359671 Committed r240235: <https://trac.webkit.org/changeset/240235>
WebKit Commit Bot
Comment 4 2019-01-21 09:22:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.