Summary: | [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||
Component: | WebKitGTK | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | agomez, aperez, bugs-noreply, clopez, ews-watchlist, ltilve, mcatanzaro, webkit-bug-importer | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
I'm using GCC 8.2.0 and Ubuntu 18.10.
> fujii@ubuntu $ gcc --version ~/tmp/libgcrypt-1.8.4
> gcc (Ubuntu 8.2.0-7ubuntu1) 8.2.0
> Copyright (C) 2018 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> fujii@ubuntu $ lsb_release -a ~/tmp/libgcrypt-1.8.4
> No LSB modules are available.
> Distributor ID: Ubuntu
> Description: Ubuntu 18.10
> Release: 18.10
> Codename: cosmic
> fujii@ubuntu $ ~/tmp/libgcrypt-1.8.4
I've confirmed libgcrypt-1.8.4.tar.bz2 can compile. The following commit removed the memcpy of _gcry_aes_ssse3_do_setkey. https://github.com/gpg/libgcrypt/commit/54c57bc49edb5c00e9ed8103cc4837bb72c5e863 I've found openSUSE is working around a similar issue by setting -U_FORTIFY_SOURCE to CFLAGS. https://www.mail-archive.com/opensuse-commit@opensuse.org/msg135244.html I've confirmed this trick can address the issue of libgcrypt-1.7.6.tar.bz2 for me. Created attachment 359669 [details]
Patch to bump libgcrypt
Comment on attachment 359669 [details] Patch to bump libgcrypt Clearing flags on attachment: 359669 Committed r240245: <https://trac.webkit.org/changeset/240245> All reviewed patches have been landed. Closing bug. |
[GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10 update-webkitgtk-libs is failing with the following error. > /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher -I.. -I../src -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/src -I/home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Root/include -Wno-error -O2 -g1 -fvisibility=hidden -Wall -MT camellia.lo -MD -MP -MF .deps/camellia.Tpo -c -o camellia.lo /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/camellia.c > In file included from /usr/include/features.h:424, > from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, > from /usr/include/stdio.h:27, > from /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/rijndael-ssse3-amd64.c:38: > /home/fujii/webkit/ga/WebKitBuild/DependenciesGTK/Source/libgcrypt-1.7.6/cipher/rijndael-ssse3-amd64.c: In function '_gcry_aes_ssse3_do_setkey': > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:31:1: error: inlining failed in call to always_inline 'memcpy': target specific option mismatch > __NTH (memcpy (void *__restrict __dest, const void *__restrict __src, > ^~~~~