Bug 193623

Summary: AX: [GTK] Layout test accessibility/set-selected-editable.html is failing
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cfleizach, commit-queue, ericliang, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Michael Catanzaro 2019-01-20 12:26:58 PST
Layout test accessibility/set-selected-editable.html has been failing for GTK since it was added in r240205:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/set-selected-editable-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/set-selected-editable-actual.txt
@@ -4,30 +4,30 @@
 
 
 PASS axElement.isAttributeSettable('AXSelected') is false
-PASS axElement.isAttributeSettable('AXSelected') is true
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
 PASS axElement.isAttributeSettable('AXSelected') is false
 PASS axElement.isAttributeSettable('AXSelected') is false
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
 PASS axElement.isAttributeSettable('AXSelected') is false
-PASS axElement.isAttributeSettable('AXSelected') is true
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
 PASS axElement.isAttributeSettable('AXSelected') is false
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
 PASS axElement.isAttributeSettable('AXSelected') is false
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
-PASS axElement.isAttributeSettable('AXSelected') is true
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
+FAIL axElement.isAttributeSettable('AXSelected') should be true. Was false.
 PASS axElement.isAttributeSettable('AXSelected') is false
 PASS axElement.isAttributeSettable('AXSelected') is false
 PASS axElement.isAttributeSettable('AXSelected') is false
Comment 1 Radar WebKit Bug Importer 2019-01-20 12:27:26 PST
<rdar://problem/47416790>
Comment 2 Eric Liang 2019-01-22 11:55:48 PST
Created attachment 359758 [details]
Patch
Comment 3 Eric Liang 2019-01-22 11:58:14 PST
Created attachment 359760 [details]
Patch
Comment 4 Michael Catanzaro 2019-01-22 12:13:03 PST
Comment on attachment 359760 [details]
Patch

OK, fair enough.
Comment 5 WebKit Commit Bot 2019-01-23 10:00:23 PST
Comment on attachment 359760 [details]
Patch

Clearing flags on attachment: 359760

Committed r240344: <https://trac.webkit.org/changeset/240344>
Comment 6 WebKit Commit Bot 2019-01-23 10:00:25 PST
All reviewed patches have been landed.  Closing bug.