Summary: | Frags on current page don't generate "navigation-requested" events | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Scorgie <Don> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | a9016009, alp, dmacks, fpeters, gustavo | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Don Scorgie
2008-06-02 11:17:07 PDT
Hey. I'm looking at Yelp, and noticed this bug in a comment. I may have misunderstood something about the problem, but I think this problem is gone for a while now. The signal is emitted in both links of the example for me, without passing arguments for the program. Can you confirm my investigation is correct? I traced it back to FrameLoader::checkNavigationPolicy, which exits early at // We are always willing to show alternate content for unreachable URLs; // treat it like a reload so it maintains the right state for b/f list. if (loader->substituteData().isValid() && !loader->substituteData().failingURL().isEmpty()) { if (isBackForwardLoadType(m_policyLoadType)) m_policyLoadType = FrameLoadTypeReload; function(argument, request, 0, true); return; } and therefore skips the m_client->dispatchDecidePolicyForNavigationAction() which would emit the signal. From there, however, I do not know where to go :/ Created attachment 35066 [details]
fix SubstituteData creation
WebKit/gtk/ChangeLog | 13 +++++++++++++
WebKit/gtk/webkit/webkitwebframe.cpp | 4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
Comment on attachment 35066 [details]
fix SubstituteData creation
r=me
Created attachment 35071 [details]
fix SubstituteData creation
WebKit/gtk/ChangeLog | 14 ++++++++++++++
WebKit/gtk/webkit/webkitwebframe.cpp | 2 +-
2 files changed, 15 insertions(+), 1 deletions(-)
Created attachment 35072 [details]
fix SubstituteData creation
WebKit/gtk/ChangeLog | 14 ++++++++++++++
WebKit/gtk/webkit/webkitwebframe.cpp | 2 +-
2 files changed, 15 insertions(+), 1 deletions(-)
Comment on attachment 35072 [details]
fix SubstituteData creation
Sorry for the spam. So, it looks like we are also using the baseKURL incorrectly. This patch makes both the normal reload, and the 'try again' work on error pages, in addition to fixing this bug.
Comment on attachment 35072 [details]
fix SubstituteData creation
r=me
|