Bug 193591

Summary: Separate out outline-style: auto user-agent appearance from Mac animated focus ring drawing
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mcatanzaro, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193583
https://bugs.webkit.org/show_bug.cgi?id=193581
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Daniel Bates
Reported 2019-01-18 13:51:05 PST
Currently the focus ring appearance for outline-style: auto is tangled with the Mac animated focus ring logic. We should separate them so that a non-Mac port can opt-into the former and opt-out of the latter. In particular, the iOS ports wants to opt into the former and opt-out of the latter.
Attachments
Patch (10.24 KB, patch)
2019-01-18 14:01 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (7.42 KB, patch)
2019-01-18 14:30 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2019-02-10 10:44 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2019-01-18 14:01:10 PST
Created attachment 359536 [details] Patch
Simon Fraser (smfr)
Comment 2 2019-01-18 14:10:26 PST
Comment on attachment 359536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359536&action=review > Source/WebCore/page/Settings.yaml:799 > +usePlatformFocusRingColorForOutlineStyleAuto: > + initial: defaultUsePlatformFocusRingColorForOutlineStyleAuto() > + > +useShrinkWrappedFocusRingForOutlineStyleAuto: > + initial: defaultUseShrinkWrappedFocusRingForOutlineStyleAuto() Do you really need settings here, or can you just have a static function somewhere whose return values depend on #ifdefs? I think Settings are only useful if you are ever going to change them at runtime, e.g. for testing. I could imagine some static methods on Theme/RenderTheme, for instance.
Daniel Bates
Comment 3 2019-01-18 14:30:01 PST
Created attachment 359540 [details] Patch
Daniel Bates
Comment 4 2019-02-10 10:44:12 PST
Created attachment 361633 [details] Patch
Daniel Bates
Comment 5 2019-02-10 10:45:09 PST
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 359536 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=359536&action=review > > > Source/WebCore/page/Settings.yaml:799 > > +usePlatformFocusRingColorForOutlineStyleAuto: > > + initial: defaultUsePlatformFocusRingColorForOutlineStyleAuto() > > + > > +useShrinkWrappedFocusRingForOutlineStyleAuto: > > + initial: defaultUseShrinkWrappedFocusRingForOutlineStyleAuto() > > Do you really need settings here, or can you just have a static function > somewhere whose return values depend on #ifdefs? > Took this approach.
Daniel Bates
Comment 6 2019-02-11 11:00:13 PST
Comment on attachment 361633 [details] Patch Clearing flags on attachment: 361633 Committed r241271: <https://trac.webkit.org/changeset/241271>
Daniel Bates
Comment 7 2019-02-11 11:00:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-02-11 11:02:42 PST
<rdar://problem/47970888>
Note You need to log in before you can comment on or make changes to this bug.