Bug 193581

Summary: LayoutTests/fast/inline/{continuation-outlines, continuation-outlines-with-layers}.html should have purple outline, but has blue outline
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: bfulgham, simon.fraser, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193583
https://bugs.webkit.org/show_bug.cgi?id=193591
Attachments:
Description Flags
[Screenshot] WebKit r240151
none
[Screenshot] Mac Chrome Canary 73.0.3674.0
none
[Screenshot] Mac Firefox 64.0.2 none

Description Daniel Bates 2019-01-18 10:25:56 PST
Compare the rendering of the color of the outline in LayoutTests/fast/inline/{continuation-outlines, continuation-outlines-with-layers}.html in Safari, Chrome, and Firefox.

ToT WebKit (r240151) renders the outline in the system blue. But Chrome Canary 73.0.3674.0 and Firefox 64.0.2 render them in purple.
Comment 1 Daniel Bates 2019-01-18 10:26:41 PST
Created attachment 359504 [details]
[Screenshot] WebKit r240151

Screenshot of rendering of LayoutTests/fast/inline/continuation-outlines.html.
Comment 2 Daniel Bates 2019-01-18 10:27:03 PST
Created attachment 359505 [details]
[Screenshot] Mac Chrome Canary 73.0.3674.0

Screenshot of rendering of LayoutTests/fast/inline/continuation-outlines.html.
Comment 3 Daniel Bates 2019-01-18 10:27:27 PST
Created attachment 359506 [details]
[Screenshot] Mac Firefox 64.0.2

Screenshot of rendering of LayoutTests/fast/inline/continuation-outlines.html.
Comment 4 Simon Fraser (smfr) 2019-01-18 11:24:47 PST
https://drafts.csswg.org/css-ui-3/#outline-style says:

The auto value permits the user agent to render a custom outline style, typically a style which is either a user interface default for the platform, or perhaps a style that is richer than can be described in detail in CSS, e.g. a rounded edge outline with semi-translucent outer pixels that appears to glow. As such, this specification does not define how the outline-color is incorporated or used (if at all) when rendering auto style outlines. User agents may treat auto as solid.
Comment 5 Daniel Bates 2019-01-18 14:04:31 PST
(In reply to Simon Fraser (smfr) from comment #4)
> https://drafts.csswg.org/css-ui-3/#outline-style says:
> 
> The auto value permits the user agent to render a custom outline style,
> typically a style which is either a user interface default for the platform,
> or perhaps a style that is richer than can be described in detail in CSS,
> e.g. a rounded edge outline with semi-translucent outer pixels that appears
> to glow. As such, this specification does not define how the outline-color
> is incorporated or used (if at all) when rendering auto style outlines. User
> agents may treat auto as solid.

I see. Then this behavior is intended though we should factor out this decision into a setting to untangle it from the Mac-specific animated focus ring drawing code. This will allow iOS to opt-into using the platform focus ring color over the CSS outline-color, but opt-out of using the animated drawFocusRing() overloads. Will add this setting as part of bug #193591.