Bug 193576

Summary: [GTK][WPE] Make debug-test-runner work
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, cturner, dbates, don.olmstead, ews-watchlist, fujii.hironori, lforschler, mcatanzaro, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adrian Perez
Reported 2019-01-18 08:06:49 PST
Currently the “debug-test-runner” works only for the Mac port, and it would be quite handy to have it work with the WPE and GTK+ ports.
Attachments
Patch (3.38 KB, patch)
2019-01-18 08:43 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.35 KB, patch)
2019-08-21 13:56 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2019-01-18 08:43:44 PST
Created attachment 359495 [details] Patch Note that I have almost never touched Perl code, so hopefully this patch is not too bad O:-) With the changes suggested in the patch it is possible to get WebKitTestRunner under GDB on GNU/Linux for many layout tests. Note that the intention is *not* to replicate all of possible modes of operation of run-webkit-tests, so for example tests which need a running HTTP server will not work. Most tests will, however, and having the script working is already being handy for me to investigate assertions. I think it would be valuable to have these changes landed upstream. Tu use, do something like: % build-webkit --debug --gtk % debug-test-runner --debug --gtk LayoutTests/fast/dom/location-hash.html Note that you will need a running X11 server or Wayland compositor accordingly. No attempt is made at running Xvfb or headless Weston.
Adrian Perez
Comment 2 2019-08-21 13:56:34 PDT
Created attachment 376917 [details] Patch for landing
WebKit Commit Bot
Comment 3 2019-08-21 14:49:06 PDT
Comment on attachment 376917 [details] Patch for landing Clearing flags on attachment: 376917 Committed r248965: <https://trac.webkit.org/changeset/248965>
WebKit Commit Bot
Comment 4 2019-08-21 14:49:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-21 14:51:33 PDT
<rdar://problem/54573003>
Note You need to log in before you can comment on or make changes to this bug.