Bug 193566 – WebKit failed with lots of error C1083 when built by msvc on Windows

• Component: CMake
• Status: RESOLVED INVALID

[QuellaZhang]

WebKit failed with lots of "error C1083:  Cannot open include file: 'WebKitLegacy/WebKit.h': No such file or directory" and "error C1083:  Cannot open include file: 'ColorSpaceData.h'" when build by msvc on Windows, I use latest source 9d38cd6 on master branch. Could you help take a look at this?

Recently we added -DENABLE_WEBKIT_LEGACY="OFF" to the cmake build command, so the build failed. It used to be a successful build without this option.

Repro steps:
1. git clone https://github.com/WebKit/webkit d:\WebKit\src
2. open a VS 2017 x86 command prompt as admin and browse to D:\Webkit
3. extra WebKitSupportLibrary\win to D:\WebKit\src\WebKitLibraries\win
4. extra WebKitAuxiliaryLibrary\win to D:\WebKit\src\WebKitLibraries\win
5. set path=C:\gnuwin32\bin;%path%
6. cmake -G "Visual Studio 15 2017" -DCMAKE_SYSTEM_VERSION=10.0.17134.0 -DCMAKE_BUILD_TYPE=Release -DRUBY_LIBRARY=C:\Ruby25-x64\lib -DPORT="AppleWin" -DENABLE_WEBKIT_LEGACY="OFF" ..\src
7. msbuild /p:Configuration=Release;Platform=Win32 WebKit.sln /t:Rebuild

Failures(see attachment):
D:\WebKit\src\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.h(32,10): error C1083:  Cannot open include file: 'WebKitLegacy/WebKit.h': No such file or directory (d:\agent\_work\3\s\src\vctools\Compiler\CxxFE\sl\p1\c\p0prepro.c:1709) [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
D:\WebKit\src\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.h(32,10): error C1083: #include <WebKitLegacy/WebKit.h> [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
D:\WebKit\src\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.h(32,10): error C1083:          ^ (compiling source file D:\WebKit\src\Tools\DumpRenderTree\win\DRTDesktopNotificationPresenter.cpp) [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
D:\WebKit\src\Tools\DumpRenderTree\win\FrameLoadDelegate.h(32,10): error C1083:  Cannot open include file: 'WebKitLegacy/WebKit.h': No such file or directory (d:\agent\_work\3\s\src\vctools\Compiler\CxxFE\sl\p1\c\p0prepro.c:1709) [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
D:\WebKit\src\Tools\DumpRenderTree\win\FrameLoadDelegate.h(32,10): error C1083: #include <WebKitLegacy/WebKit.h> [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]
D:\WebKit\src\Tools\DumpRenderTree\win\FrameLoadDelegate.h(32,10): error C1083:          ^ (compiling source file D:\WebKit\src\Tools\DumpRenderTree\win\FrameLoadDelegate.cpp) [D:\WebKit\build_x86\Tools\DumpRenderTree\DumpRenderTreeLib.vcxproj]

[QuellaZhang]

Created attachment 359453 [details]
build log

[Don Olmstead]

(In reply to QuellaZhang from comment #0)
> WebKit failed with lots of "error C1083:  Cannot open include file:
> 'WebKitLegacy/WebKit.h': No such file or directory" and "error C1083: 
> Cannot open include file: 'ColorSpaceData.h'" when build by msvc on Windows,
> I use latest source 9d38cd6 on master branch. Could you help take a look at
> this?
> 
> Recently we added -DENABLE_WEBKIT_LEGACY="OFF" to the cmake build command,
> so the build failed. It used to be a successful build without this option.

The AppleWin port builds WEBKIT_LEGACY. WinCairo builds WEBKIT_LEGACY and WEBKIT. By turning ENABLE_WEBKIT_LEGACY to OFF you triggered building of modern WebKit.