Bug 193526

Summary: [JSC] Add generateHeapSnapshotForGCDebugging function to dump GCDebugging data
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Yusuke Suzuki 2019-01-16 20:32:56 PST 
[JSC] Add a mode to generateHeapSnapshot function to dump GCDebugging data
Comment 1 Yusuke Suzuki 2019-01-16 20:46:18 PST 
Created attachment 359346 [details]
Patch
Comment 2 Yusuke Suzuki 2019-01-16 22:57:56 PST 
Comment on attachment 359346 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359346&action=review

> Source/JavaScriptCore/ChangeLog:13
> +        multiple times for debugging. Currently, it only generates a large string, which is easily distinguishable in the heap inspector tool.

This is why this patch adds a new generateHeapSnapshotForGCDebugging, while we already have functionGenerateHeapSnapshot.
Comment 3 Michael Saboff 2019-01-17 08:37:27 PST 
Comment on attachment 359346 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2019-01-17 09:07:21 PST 
Comment on attachment 359346 [details]
Patch

Thanks!
Comment 5 WebKit Commit Bot 2019-01-17 09:32:44 PST 
Comment on attachment 359346 [details]
Patch

Clearing flags on attachment: 359346

Committed r240113: <https://trac.webkit.org/changeset/240113>
Comment 6 WebKit Commit Bot 2019-01-17 09:32:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-01-17 09:33:37 PST 
<rdar://problem/47353310>