Summary: | clang-tidy: Fix unnecessary copy/ref churn of for loop variables in libwebrtc | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | WebRTC | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.chromium.org/p/webrtc/issues/detail?id=10215 | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2019-01-16 10:45:37 PST
Created attachment 359283 [details]
Patch v1
Comment on attachment 359283 [details] Patch v1 Can we try upstreaming these changes? View in context: https://bugs.webkit.org/attachment.cgi?id=359283&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:440 > + for (const rtcp::ReportBlock& report_block : sender_report.report_blocks()) Could use auto here. Comment on attachment 359283 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=359283&action=review >> Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc:440 >> + for (const rtcp::ReportBlock& report_block : sender_report.report_blocks()) > > Could use auto here. I debated doing that, but went with principle of least change. Comment on attachment 359283 [details] Patch v1 Clearing flags on attachment: 359283 Committed r240053: <https://trac.webkit.org/changeset/240053> All reviewed patches have been landed. Closing bug. |