Summary: | StringObjectUse should not be a structure check for the original string object structure | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, mcatanzaro, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Saam Barati
2019-01-15 19:45:33 PST
Created attachment 359354 [details]
patch
Comment on attachment 359354 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359354&action=review r=me with FTL fixes > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:6335 > + LValue type = m_out.load32(cell, m_heaps.JSCell_typeInfoType); load8ZeroExt32? > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:16068 > + LValue type = m_out.load32(cellBase, m_heaps.JSCell_typeInfoType); Ditto. > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:16088 > + LValue type = m_out.load32(cell, m_heaps.JSCell_typeInfoType); Ditto. Comment on attachment 359354 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=359354&action=review >> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:6335 >> + LValue type = m_out.load32(cell, m_heaps.JSCell_typeInfoType); > > load8ZeroExt32? Oops. Will fix Created attachment 359359 [details]
patch for landing
Comment on attachment 359359 [details] patch for landing Clearing flags on attachment: 359359 Committed r240114: <https://trac.webkit.org/changeset/240114> All reviewed patches have been landed. Closing bug. Committed r240225: <https://trac.webkit.org/changeset/240225> |