Bug 193468

Summary: Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2019-01-15 15:12:11 PST
Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
Attachments
Patch (1.75 KB, patch)
2019-01-15 15:15 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2019-01-16 11:27 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2019-01-16 11:53 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2019-01-15 15:15:18 PST
Created attachment 359211 [details] Patch
Tim Horton
Comment 2 2019-01-15 15:15:21 PST
<rdar://problem/38645869>
WebKit Commit Bot
Comment 3 2019-01-15 15:55:43 PST
Comment on attachment 359211 [details] Patch Clearing flags on attachment: 359211 Committed r240016: <https://trac.webkit.org/changeset/240016>
WebKit Commit Bot
Comment 4 2019-01-15 15:55:44 PST
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 5 2019-01-16 11:27:48 PST
Reopening to attach new patch.
Tim Horton
Comment 6 2019-01-16 11:27:49 PST
Created attachment 359284 [details] Patch
zalan
Comment 7 2019-01-16 11:41:27 PST
Comment on attachment 359284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359284&action=review > Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:375 > + IntSize documentSize = renderView->unscaledDocumentRect().size(); It's probably not the case but this second layoutIfNeeded() could potentially nuke the frame as well.
Tim Horton
Comment 8 2019-01-16 11:53:50 PST
Created attachment 359286 [details] Patch
WebKit Commit Bot
Comment 9 2019-01-16 12:35:16 PST
Comment on attachment 359286 [details] Patch Clearing flags on attachment: 359286 Committed r240045: <https://trac.webkit.org/changeset/240045>
WebKit Commit Bot
Comment 10 2019-01-16 12:35:18 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.