Bug 193468

Summary: Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Horton 2019-01-15 15:12:11 PST 
Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
Comment 1 Tim Horton 2019-01-15 15:15:18 PST 
Created attachment 359211 [details]
Patch
Comment 2 Tim Horton 2019-01-15 15:15:21 PST 
<rdar://problem/38645869>
Comment 3 WebKit Commit Bot 2019-01-15 15:55:43 PST 
Comment on attachment 359211 [details]
Patch

Clearing flags on attachment: 359211

Committed r240016: <https://trac.webkit.org/changeset/240016>
Comment 4 WebKit Commit Bot 2019-01-15 15:55:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Tim Horton 2019-01-16 11:27:48 PST 
Reopening to attach new patch.
Comment 6 Tim Horton 2019-01-16 11:27:49 PST 
Created attachment 359284 [details]
Patch
Comment 7 zalan 2019-01-16 11:41:27 PST 
Comment on attachment 359284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359284&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:375
> +    IntSize documentSize = renderView->unscaledDocumentRect().size();

It's probably not the case but this second layoutIfNeeded() could potentially nuke the frame as well.
Comment 8 Tim Horton 2019-01-16 11:53:50 PST 
Created attachment 359286 [details]
Patch
Comment 9 WebKit Commit Bot 2019-01-16 12:35:16 PST 
Comment on attachment 359286 [details]
Patch

Clearing flags on attachment: 359286

Committed r240045: <https://trac.webkit.org/changeset/240045>
Comment 10 WebKit Commit Bot 2019-01-16 12:35:18 PST 
All reviewed patches have been landed.  Closing bug.