Bug 193443 – clang-tidy: Fix unnecessary copy of for loop variables in ANGLE

• Component: ANGLE
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Running clang-tidy on ANGLE resulted in these potential performance improvements to prevent object copies in for loops:

Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1070:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
    for (auto block : uniformBlocks)
              ^
         const  &
Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1087:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
        for (auto var : outputVaryings)
                  ^
             const  &
Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:1100:19: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
        for (auto var : outputVariables)
                  ^
             const  &

Source/ThirdParty/ANGLE/src/compiler/preprocessor/MacroExpander.cpp:73:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
    for (auto macro : mExpander->mMacrosToReenable)
              ^
         const  &

Source/ThirdParty/ANGLE/src/libANGLE/Program.cpp:195:15: warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
    for (auto nameInSet : nameSet)
              ^
         const  &

[David Kilzer (:ddkilzer)]

Created attachment 359156 [details]
Patch v1

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[WebKit Commit Bot]

Comment on attachment 359156 [details]
Patch v1

Clearing flags on attachment: 359156

Committed r240001: <https://trac.webkit.org/changeset/240001>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/47295060>