Bug 193410

Summary:

Remove redundant check for alignAttr and hiddenAttr in various isPresentationAttribute overrides

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Cleanup	none
Cleanup	simon.fraser: review+

Ryosuke Niwa

Reported 2019-01-14 14:35:16 PST

HTMLElement::isPresentationAttribute checks for alignAttr and hiddenAttr. There is no need to check them in HTMLElement's subclasses' isPresentationAttribute

Attachments
Cleanup (11.66 KB, patch) 2019-01-14 14:37 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Cleanup (11.67 KB, patch) 2019-01-14 14:40 PST, Ryosuke Niwa	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2019-01-14 14:37:38 PST

Created attachment 359081 [details] Cleanup

Ryosuke Niwa

Comment 2 2019-01-14 14:40:31 PST

Created attachment 359082 [details] Cleanup

Ryosuke Niwa

Comment 3 2019-01-14 14:51:58 PST

Committed r239952: <https://trac.webkit.org/changeset/239952>

Radar WebKit Bug Importer

Comment 4 2019-01-14 14:52:28 PST

<rdar://problem/47266787>

Note You need to log in before you can comment on or make changes to this bug.