Summary: | [GTK][STABLE] Build fails with OpenGL disabled due to missing PlatformWheelEvent::isEndOfNonMomentumScroll() | ||
---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> |
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | cgarcia, lforschler, mcatanzaro |
Priority: | P2 | ||
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Linux |
Description
Adrian Perez
2019-01-12 07:50:08 PST
(In reply to Michael Catanzaro from comment #1) > Maybe fixed in trunk by r238928? Yes, that's my guess as well. I am leaving a Buildroot compilation overnight with the same settings as the autobuilder *and* r238928 applied to see whether that works. Thanks! (In reply to Adrian Perez from comment #2) > (In reply to Michael Catanzaro from comment #1) > > Maybe fixed in trunk by r238928? > > Yes, that's my guess as well. I am leaving a Buildroot compilation > overnight with the same settings as the autobuilder *and* r238928 > applied to see whether that works. Thanks! It turns out that applying only r238928 is not enough, with it applied a different build error shows up: In file included from /home/aperez/devel/wpe/buildroot/ttt/build/webkitgtk-2.22.5/DerivedSources/WebCore/unified-sources/UnifiedSource322.cpp:8:0: /home/aperez/devel/wpe/buildroot/ttt/build/webkitgtk-2.22.5/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp: In member function ‘virtual bool WebCore::ScrollAnimatorGtk::handleWheelEvent(const WebCore::PlatformWheelEvent&)’: /home/aperez/devel/wpe/buildroot/ttt/build/webkitgtk-2.22.5/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:135:15: error: ‘const class WebCore::PlatformWheelEvent’ has no member named ‘isEndOfNonMomentumScroll’ if (event.isEndOfNonMomentumScroll()) { ^~~~~~~~~~~~~~~~~~~~~~~~ /home/aperez/devel/wpe/buildroot/ttt/build/webkitgtk-2.22.5/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp:140:15: error: ‘const class WebCore::PlatformWheelEvent’ has no member named ‘isTransitioningToMomentumScroll’ if (event.isTransitioningToMomentumScroll()) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Buildroot is shipping WebKitGTK 2.26.x, this issue is not a problem anymore. |