Summary: | AXSelected attribute on RadioButton should not be settable. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Liang <ericliang> | ||||||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-feeder, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||||||
Priority: | P3 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Eric Liang
2019-01-11 16:46:58 PST
Created attachment 359438 [details]
Patch
Attachment 359438 [details] did not pass style-queue:
ERROR: LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 359439 [details]
Patch
Comment on attachment 359439 [details] Patch Attachment 359439 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10791412 New failing tests: accessibility/set-selected-editable.html Created attachment 359445 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 359439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359439&action=review > LayoutTests/accessibility/set-selected-editable.html:93 > + var axElement = accessibilityController.accessibleElementById("test" + i); probably simpler if you encode the true/false values into the DOM as a attribute on the nodes <div selected-expected-value="true" then you don't neeed this list Created attachment 359500 [details]
Patch
Comment on attachment 359500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359500&action=review > LayoutTests/accessibility/set-selected-editable.html:9 > +<div id="test0" role="table" selected-expected-value="false"> can you put all this stuff in a <div> and then at the end of the test mark div.style.visibility = hidden; so that the first 17 lines in the expected file is not garbage. the results file will just look like a series of PASS then... thanks > LayoutTests/platform/win/TestExpectations:1482 > +webkit.org/b/193371 [ Release ] accessibility/set-selected-editable.html [ Skip ] I think if you omit Debug/Release it will just do both Created attachment 359516 [details]
Patch
Comment on attachment 359516 [details] Patch Rejecting attachment 359516 [details] from commit-queue. ericliang@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 359516 [details] Patch Clearing flags on attachment: 359516 Committed r240205: <https://trac.webkit.org/changeset/240205> All reviewed patches have been landed. Closing bug. |