Bug 193368

Summary:

Reduce use of NetworkStorageSession::defaultStorageSession in WebCore

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, dbates, ews-watchlist, galpeter, ggaren, japhet, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews105 for mac-highsierra-wk2	none
Patch	none
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	ggaren: review+

Alex Christensen

Reported 2019-01-11 14:49:38 PST

Reduce use of NetworkStorageSession::defaultStorageSession in WebCore

Attachments
Patch (5.61 KB, patch) 2019-01-11 14:50 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (6.77 KB, patch) 2019-01-11 14:51 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.43 MB, application/zip) 2019-01-11 16:32 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (2.73 MB, application/zip) 2019-01-11 16:40 PST, EWS Watchlist	no flags	Details
Patch (7.45 KB, patch) 2019-01-14 11:15 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.55 MB, application/zip) 2019-01-14 12:31 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.46 MB, application/zip) 2019-01-14 13:13 PST, EWS Watchlist	no flags	Details
Patch (20.99 KB, patch) 2019-01-15 16:27 PST, Alex Christensen	ggaren: review+	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2019-01-11 14:50:09 PST

Created attachment 358949 [details] Patch

Alex Christensen

Comment 2 2019-01-11 14:51:31 PST

Created attachment 358951 [details] Patch

EWS Watchlist

Comment 3 2019-01-11 16:32:05 PST

Comment on attachment 358951 [details] Patch Attachment 358951 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10719066 New failing tests: http/tests/cache/disk-cache/disk-cache-vary-cookie.html

EWS Watchlist

Comment 4 2019-01-11 16:32:06 PST

Created attachment 358963 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 5 2019-01-11 16:40:53 PST

Comment on attachment 358951 [details] Patch Attachment 358951 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10719465 New failing tests: http/tests/cache/disk-cache/disk-cache-vary-cookie.html

EWS Watchlist

Comment 6 2019-01-11 16:40:55 PST

Created attachment 358964 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 7 2019-01-14 11:15:21 PST

Created attachment 359055 [details] Patch

EWS Watchlist

Comment 8 2019-01-14 12:31:24 PST

Comment on attachment 359055 [details] Patch Attachment 359055 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10747529 New failing tests: http/tests/cache/disk-cache/disk-cache-vary-cookie.html

EWS Watchlist

Comment 9 2019-01-14 12:31:26 PST

Created attachment 359066 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 10 2019-01-14 13:13:39 PST

Comment on attachment 359055 [details] Patch Attachment 359055 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10747645 New failing tests: http/tests/cache/disk-cache/disk-cache-vary-cookie.html

EWS Watchlist

Comment 11 2019-01-14 13:13:41 PST

Created attachment 359072 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Alex Christensen

Comment 12 2019-01-15 16:27:10 PST

Created attachment 359221 [details] Patch

Geoffrey Garen

Comment 13 2019-01-15 21:00:36 PST

Comment on attachment 359221 [details] Patch r=me

Alex Christensen

Comment 14 2019-01-15 21:03:21 PST

http://trac.webkit.org/r240031

Radar WebKit Bug Importer

Comment 15 2019-01-15 21:04:34 PST

<rdar://problem/47306870>

Note You need to log in before you can comment on or make changes to this bug.