Bug 193357

Summary: Adopt new VCP SPI
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=194025
Bug Depends on: 194039    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch none

youenn fablet
Reported 2019-01-11 11:49:11 PST
Adopt new VCP SPI
Attachments
Patch (9.16 KB, patch)
2019-01-11 11:57 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.81 KB, patch)
2019-01-28 21:33 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.33 KB, patch)
2019-01-29 09:39 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.41 KB, patch)
2019-04-01 14:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.63 KB, patch)
2019-04-02 08:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-01-11 11:51:44 PST
<rdar://problem/43656651>
youenn fablet
Comment 2 2019-01-11 11:57:22 PST
Created attachment 358924 [details] Patch
youenn fablet
Comment 3 2019-01-28 21:33:55 PST
Created attachment 360435 [details] Patch
Eric Carlson
Comment 4 2019-01-29 05:56:35 PST
Comment on attachment 360435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=360435&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:45 > +void testCompressionOutputCallback(void *, void *, OSStatus, VTEncodeInfoFlags, CMSampleBufferRef) Nit: sanity checking the buffer and status parameters would make this even safer. > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:73 > + if (pixelFormat) { Shouldn’t these tests be done before you use the values to create the dictionary?
youenn fablet
Comment 5 2019-01-29 09:03:12 PST
(In reply to Eric Carlson from comment #4) > Comment on attachment 360435 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=360435&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:45 > > +void testCompressionOutputCallback(void *, void *, OSStatus, VTEncodeInfoFlags, CMSampleBufferRef) > > Nit: sanity checking the buffer and status parameters would make this even > safer. This cannot be called as we do not call encodeframe. If we do not have the right encoder id, session creation will just fail. > > > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:73 > > + if (pixelFormat) { > > Shouldn’t these tests be done before you use the values to create the > dictionary? OK, I'll remove the if statements since they do not help much here.
youenn fablet
Comment 6 2019-01-29 09:39:40 PST
Created attachment 360467 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-01-29 11:13:31 PST
Comment on attachment 360467 [details] Patch for landing Clearing flags on attachment: 360467 Committed r240665: <https://trac.webkit.org/changeset/240665>
WebKit Commit Bot
Comment 8 2019-01-29 11:13:32 PST
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 9 2019-01-30 13:25:05 PST
Re-opened since this is blocked by bug 194039
youenn fablet
Comment 10 2019-04-01 14:36:46 PDT
Created attachment 366424 [details] Patch
youenn fablet
Comment 11 2019-04-02 08:45:24 PDT
Created attachment 366496 [details] Patch
WebKit Commit Bot
Comment 12 2019-04-03 10:38:01 PDT
Comment on attachment 366496 [details] Patch Clearing flags on attachment: 366496 Committed r243811: <https://trac.webkit.org/changeset/243811>
WebKit Commit Bot
Comment 13 2019-04-03 10:38:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.