Bug 193347

Summary: [JSC] ModuleEnvironment do not have JSGlobalLexicalEnvironment as its upper scope
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jaffathecake, keith_miller, mark.lam, msaboff, paul.varna, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 193308    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch tzagallo: review+

Description Yusuke Suzuki 2019-01-10 21:52:49 PST
I believe it should have, according to the spec.
Comment 1 Yusuke Suzuki 2020-04-09 13:38:43 PDT
Created attachment 396002 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-09 14:36:29 PDT
Created attachment 396012 [details]
Patch
Comment 3 Tadeu Zagallo 2020-04-09 15:28:02 PDT
Comment on attachment 396012 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2020-04-09 15:49:08 PDT
Committed r259835: <https://trac.webkit.org/changeset/259835>
Comment 5 Radar WebKit Bug Importer 2020-04-09 15:50:18 PDT
<rdar://problem/61545983>
Comment 6 Yusuke Suzuki 2020-04-29 16:17:29 PDT
*** Bug 186888 has been marked as a duplicate of this bug. ***
Comment 7 Yusuke Suzuki 2021-06-24 18:20:45 PDT
*** Bug 202044 has been marked as a duplicate of this bug. ***