Summary: | Cleanup possible WK*Copy/Create leaks in WebKitTestRunner | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, ddkilzer, joepeck, lforschler, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2019-01-10 14:44:59 PST
Created attachment 358838 [details]
[PATCH] Proposed Fix
Comment on attachment 358838 [details]
[PATCH] Proposed Fix
r=me
Comment on attachment 358838 [details] [PATCH] Proposed Fix Clearing flags on attachment: 358838 Committed r239871: <https://trac.webkit.org/changeset/239871> All reviewed patches have been landed. Closing bug. Comment on attachment 358838 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=358838&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:434 > + WKRetainPtr<WKStringRef> totalPrevalentResourcesKey(AdoptWK, WKStringCreateWithUTF8CString("TotalPrevalentResources")); > + WKRetainPtr<WKStringRef> totalPrevalentResourcesWithUserInteractionKey(AdoptWK, WKStringCreateWithUTF8CString("TotalPrevalentResourcesWithUserInteraction")); > + WKRetainPtr<WKStringRef> top3SubframeUnderTopFrameOriginsKey(AdoptWK, WKStringCreateWithUTF8CString("Top3SubframeUnderTopFrameOrigins")); Please use the adoptWK function, not the special AdoptWK constructor, in new code. We want to get rid of those special constructors some day. |