[WPE] Workaround for incorrect template specialization being selected when UChar=char16_t

• Component: WPE WebKit
• Status: RESOLVED FIXED

[Charlie Turner]

[WPE] Workaround for incorrect template specialization being selected when UChar=char16_t

[Charlie Turner]

Created attachment 358821 [details]
Patch

Temporary fix for bad template deducation when ICU switched to the UChar=char16_t typedef. With this definition, the specliazation for Signed && Integral wins over the typedef for UChar

[Michael Catanzaro]

Comment on attachment 358821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358821&action=review

> Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:88
> -#if PLATFORM(WIN)
> +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59
>      EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned short>(42) , " world"));
>  #else
>      EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned short>(42) , " world")); // Treated as a character.

I wonder how many bugs this behavior difference is causing. This is really unfortunate. :/

I almost gave this r-, but the new version is better and the old approach will be obsoleted eventually. Can we remove the #if PLATFORM(WIN), though? Surely that is there because they were using newer ICU?

[Charlie Turner]

(In reply to Michael Catanzaro from comment #2)
> I almost gave this r-, but the new version is better and the old approach
> will be obsoleted eventually. Can we remove the #if PLATFORM(WIN), though?
> Surely that is there because they were using newer ICU?

IIUC, Windows hits the problem for a different reason, not sure if they use ICU, but on that platform UChar=wchar_t rather than unsigned short as assumed in this test.

[Michael Catanzaro]

Let's continue discussion of how to fix the footgun here in bug #193101.

[Charlie Turner]

Created attachment 359023 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 359023 [details]
Patch for landing

Clearing flags on attachment: 359023

Committed r239920: <https://trac.webkit.org/changeset/239920>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.