Bug 193327

Summary: Add WKBundlePage SPI to temporarily force light or dark appearance on a page
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: WebKit APIAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jlewis3, ryanhaddad, thorton, timothy, tsavell, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Timothy Hatcher
Reported 2019-01-10 11:03:43 PST
Needed to let clients switch the appearance for DOM processing explicitly in light or dark mode. <rdar://problem/47093222>
Attachments
Patch (20.81 KB, patch)
2019-01-10 11:08 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (18.73 KB, patch)
2019-01-10 11:53 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (18.78 KB, patch)
2019-01-10 12:20 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (1.20 KB, patch)
2019-01-11 11:28 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2019-01-10 11:08:09 PST
Created attachment 358808 [details] Patch
Timothy Hatcher
Comment 2 2019-01-10 11:53:20 PST
Created attachment 358813 [details] Patch
Timothy Hatcher
Comment 3 2019-01-10 12:20:02 PST
Created attachment 358818 [details] Patch
WebKit Commit Bot
Comment 4 2019-01-10 17:12:06 PST
Comment on attachment 358818 [details] Patch Clearing flags on attachment: 358818 Committed r239851: <https://trac.webkit.org/changeset/239851>
WebKit Commit Bot
Comment 5 2019-01-10 17:12:08 PST
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 6 2019-01-10 20:33:08 PST
The API test added with this change is timing out on Mojave bots: Timeout TestWebKitAPI.WebKit.ForceLightAppearanceInBundle _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL. ERROR: InjectedBundle test not found - ForceLightAppearanceInBundleTest ERROR: InjectedBundle test not found - ForceLightAppearanceInBundleTest https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/1738/steps/run-api-tests/logs/stdio
Timothy Hatcher
Comment 7 2019-01-11 11:28:03 PST
Reopening to attach new patch.
Timothy Hatcher
Comment 8 2019-01-11 11:28:03 PST
Created attachment 358916 [details] Patch
WebKit Commit Bot
Comment 9 2019-01-11 12:37:54 PST
Comment on attachment 358916 [details] Patch Clearing flags on attachment: 358916 Committed r239866: <https://trac.webkit.org/changeset/239866>
WebKit Commit Bot
Comment 10 2019-01-11 12:37:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.