Summary: | DFG combined liveness can be wrong for terminal basic blocks | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Saam Barati
2019-01-09 15:00:02 PST
Created attachment 358753 [details]
patch
Comment on attachment 358753 [details]
patch
r=me
(In reply to Yusuke Suzuki from comment #3) > Comment on attachment 358753 [details] > patch > > r=me Thanks for the review. Yusuke and I also spoke offline, and I'll make this patch fix some errors in a comment in the CombinedLiveness header. Created attachment 358955 [details]
patch for landing
Comment on attachment 358955 [details] patch for landing Clearing flags on attachment: 358955 Committed r239882: <https://trac.webkit.org/changeset/239882> All reviewed patches have been landed. Closing bug. |