Description
cvazac
2019-01-09 14:55:20 PST
Created attachment 358749 [details]
Patch
Created attachment 358750 [details]
Patch
Created attachment 358752 [details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358750&action=review > LayoutTests/imported/w3c/web-platform-tests/resource-timing/document-domain-no-impact-loader.sub.html:14 > +window.open("//{{domains[www]}}:{{ports[http][1]}}/resource-timing/resources/document-domain-no-impact.sub.html"); We should update this test to use get-host-info.sub.js. Might be better in a different patch or do that upstream and resync the tests here. > LayoutTests/imported/w3c/web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub-expected.txt:2 > +Blocked access to external URL http://www1.localhost:8801/resource-timing/resources/nested.css Ditto. Comment on attachment 358752 [details] Patch Attachment 358752 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10689922 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_dynamic_insertion.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/resource_script_types.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358757 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358752 [details] Patch Attachment 358752 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10690041 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_dynamic_insertion.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html imported/w3c/web-platform-tests/resource-timing/resource_script_types.html Created attachment 358764 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 358752 [details] Patch Attachment 358752 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10690342 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_dynamic_insertion.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/resource_script_types.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358768 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358752 [details] Patch Attachment 358752 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10691562 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_timing.worker.html imported/w3c/web-platform-tests/resource-timing/resource_dynamic_insertion.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/resource_script_types.html imported/w3c/web-platform-tests/resource-timing/buffer-full-add-after-full-event.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358773 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 358817 [details]
Patch
If tests do not provide the same results in iOS-sim, mac-wk2 and Mac-wk1, you might need to provide different -expected.txt files for them. Typically, LayoutTests/imported/w3c/.../-expected.txt will contain mac-wk2 expected file. LayoutTests/platform/ios/imported/w3c/web-platform-tests/ will be for iOS. LayoutTests/platform/ios/imported/w3c/web-platform-tests/ will be for iOS. LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/ will be for Mac-wk1. The script Tools/Scripts/update-test-expectations-from-bugzilla might help there. Comment on attachment 358817 [details] Patch Attachment 358817 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10700759 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358824 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358817 [details] Patch Attachment 358817 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10700885 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358826 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 358817 [details] Patch Attachment 358817 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10700878 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358832 [details]
Archive of layout-test-results from ews115 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358817 [details] Patch Attachment 358817 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10700988 New failing tests: imported/w3c/web-platform-tests/resource-timing/buffer-full-add-after-full-event.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358836 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 358923 [details]
Patch
Comment on attachment 358923 [details] Patch Attachment 358923 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10716321 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub.html imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.https.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358931 [details]
Archive of layout-test-results from ews101 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 358923 [details] Patch Attachment 358923 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10716580 New failing tests: imported/w3c/web-platform-tests/resource-timing/buffer-full-add-after-full-event.html imported/w3c/web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub.html imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.https.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358938 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 358923 [details] Patch Attachment 358923 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10716700 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html imported/w3c/web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub.html imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.https.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html Created attachment 358944 [details]
Archive of layout-test-results from ews113 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 358923 [details] Patch Attachment 358923 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10718616 New failing tests: imported/w3c/web-platform-tests/resource-timing/resource_redirects.html imported/w3c/web-platform-tests/resource-timing/no-entries-for-cross-origin-css-fetched.sub.html imported/w3c/web-platform-tests/resource-timing/resource_memory_cached.sub.html imported/w3c/web-platform-tests/resource-timing/resource_connection_reuse.https.html Created attachment 358956 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 359049 [details]
Patch
Comment on attachment 359049 [details] Patch Attachment 359049 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10746307 New failing tests: imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html Created attachment 359052 [details]
Archive of layout-test-results from ews100 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 359049 [details] Patch Attachment 359049 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10746531 New failing tests: imported/w3c/web-platform-tests/resource-timing/test_resource_timing.https.html Created attachment 359059 [details]
Archive of layout-test-results from ews116 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 359049 [details] Patch Attachment 359049 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10746714 New failing tests: imported/w3c/web-platform-tests/resource-timing/buffer-full-add-after-full-event.html Created attachment 359063 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 359067 [details]
Patch
Created attachment 359076 [details]
Patch
Comment on attachment 359076 [details]
Patch
Will cq+ it once it is all green
Comment on attachment 359076 [details] Patch Clearing flags on attachment: 359076 Committed r239959: <https://trac.webkit.org/changeset/239959> All reviewed patches have been landed. Closing bug. |