Bug 193294 – REGRESSION (r237658): Tap highlight limits cause the highlight to no longer show with legitimate button sizes

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

The new tap highlight limits () make some <button>s with reasonable sizes not have any tap feedback, making them feel broken.

[alan]

<rdar://problem/46006678>

[alan]

Created attachment 358727 [details]
Patch

[EWS Watchlist]

Attachment 358727 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebPageProxy.h:1783:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 358727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358727&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:245
> +        BOOL useHeuristicToDecideToPaint { false };

nodeHasBuiltInClickHandling?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:728
> +        send(Messages::WebPageProxy::DidGetTapHighlightGeometries(requestID, highlightColor, quads, roundedIntSize(borderRadii.topLeft()), roundedIntSize(borderRadii.topRight()), roundedIntSize(borderRadii.bottomLeft()), roundedIntSize(borderRadii.bottomRight()), !is<HTMLInputElement>(node)));

Need to ensure that <button> and <label> work too. Maybe use willRespondToMouseClickEvents().

[alan]

Created attachment 358731 [details]
Patch

[EWS Watchlist]

Attachment 358731 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebPageProxy.h:1783:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

Created attachment 358732 [details]
Patch

[Wenson Hsieh]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 358727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358727&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:245
> > +        BOOL useHeuristicToDecideToPaint { false };
> 
> nodeHasBuiltInClickHandling?
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:728
> > +        send(Messages::WebPageProxy::DidGetTapHighlightGeometries(requestID, highlightColor, quads, roundedIntSize(borderRadii.topLeft()), roundedIntSize(borderRadii.topRight()), roundedIntSize(borderRadii.bottomLeft()), roundedIntSize(borderRadii.bottomRight()), !is<HTMLInputElement>(node)));
> 
> Need to ensure that <button> and <label> work too. Maybe use
> willRespondToMouseClickEvents().

Would using willRespondToMouseClickEvents() regress <rdar://problem/43615142>?

[EWS Watchlist]

Attachment 358732 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebPageProxy.h:1783:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[alan]

Created attachment 358804 [details]
Patch

[EWS Watchlist]

Attachment 358804 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/WebPageProxy.h:1783:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 358804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358804&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:730
> +        auto nodeHasBuiltInClickHandling = is<HTMLFormControlElement>(*node) || is<HTMLAnchorElement>(*node) || is<HTMLLabelElement>(*node) || is<HTMLSummaryElement>(*node) || node->isLink();

auto -> bool

[alan]

Committed r239843: <https://trac.webkit.org/changeset/239843>