Bug 193266

Summary: Replace SessionTracker with HashMap member of NetworkProcess
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, ews-watchlist, joepeck, rniwa, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch joepeck: review+

Alex Christensen
Reported 2019-01-08 16:26:54 PST
Replace SessionTracker with HashMap member of NetworkProcess
Attachments
Patch (50.91 KB, patch)
2019-01-08 16:27 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (50.47 KB, patch)
2019-01-08 18:32 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (53.45 KB, patch)
2019-01-08 20:39 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.87 MB, application/zip)
2019-01-08 21:55 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (149.23 MB, application/zip)
2019-01-08 22:52 PST, EWS Watchlist 		no flags
Details
Patch (53.62 KB, patch)
2019-01-09 11:48 PST, Alex Christensen 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-08 16:27:59 PST
Created attachment 358652 [details] Patch
Alex Christensen
Comment 2 2019-01-08 18:32:04 PST
Created attachment 358659 [details] Patch
Alex Christensen
Comment 3 2019-01-08 20:39:55 PST
Created attachment 358664 [details] Patch
EWS Watchlist
Comment 4 2019-01-08 21:55:38 PST
Comment on attachment 358664 [details] Patch Attachment 358664 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10680306 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 5 2019-01-08 21:55:39 PST
Created attachment 358672 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2019-01-08 22:52:04 PST
Comment on attachment 358664 [details] Patch Attachment 358664 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10680443 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 7 2019-01-08 22:52:13 PST
Created attachment 358675 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Alex Christensen
Comment 8 2019-01-09 11:48:56 PST
Created attachment 358720 [details] Patch
Joseph Pecoraro
Comment 9 2019-01-09 19:04:14 PST
Comment on attachment 358720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358720&action=review r=me > Source/WebKit/NetworkProcess/Downloads/DownloadManager.h:75 > + virtual NetworkSession* networkSession(const PAL::SessionID&) = 0; This looks like a getter, could be made const, but not really important.
Alex Christensen
Comment 10 2019-01-09 19:08:22 PST
Great idea! Done! http://trac.webkit.org/r239815
Radar WebKit Bug Importer
Comment 11 2019-01-09 19:12:21 PST
<rdar://problem/47167364>
Truitt Savell
Comment 12 2019-01-10 08:35:19 PST
Looks like https://trac.webkit.org/changeset/239815/webkit has caused http/tests/workers/service/serviceworker-private-browsing.https.html to become a consistent timeout. History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fserviceworker-private-browsing.https.html Reproduced with: run-webkit-tests --root testbuild-239815 http/tests/workers/service/serviceworker-private-browsing.https.html --iterations 50 -f I got a %50 timeout rate locally with r239815 and no timeouts on 239814
Alex Christensen
Comment 13 2019-01-10 09:43:49 PST
I'm looking into it
Alex Christensen
Comment 14 2019-01-10 10:32:51 PST
Fix is in https://bugs.webkit.org/show_bug.cgi?id=193325
Note You need to log in before you can comment on or make changes to this bug.