Bug 193247

Summary: [WebGPU] Update createRenderPipeline for WebGPUPipelineLayout
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Justin Fan
Reported 2019-01-08 11:40:42 PST
[WebGPU] Update PipelineLayout::create for MTLArgumentEncoders
Attachments
Patch (15.62 KB, patch)
2019-01-08 11:56 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch (15.61 KB, patch)
2019-01-08 11:59 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.52 KB, patch)
2019-01-08 12:58 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-01-08 11:56:20 PST
Created attachment 358617 [details] Patch
Justin Fan
Comment 2 2019-01-08 11:59:59 PST
Created attachment 358618 [details] Patch
Justin Fan
Comment 3 2019-01-08 12:01:07 PST
<rdar://problem/46908800>
Dean Jackson
Comment 4 2019-01-08 12:05:57 PST
Comment on attachment 358618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358618&action=review > Source/WebCore/platform/graphics/gpu/GPURenderPipelineDescriptor.h:47 > + // Needed, as aggregate initialization of derived structs is not supported until C++17. I don't think we need this comment.
Justin Fan
Comment 5 2019-01-08 12:58:26 PST
Created attachment 358626 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-01-08 13:36:27 PST
Comment on attachment 358626 [details] Patch for landing Clearing flags on attachment: 358626 Committed r239744: <https://trac.webkit.org/changeset/239744>
WebKit Commit Bot
Comment 7 2019-01-08 13:36:28 PST
All reviewed patches have been landed. Closing bug.
Justin Fan
Comment 8 2019-01-08 16:31:33 PST
<rdar://problem/46908800>
Justin Fan
Comment 10 2019-01-14 12:44:16 PST
(In reply to Truitt Savell from comment #9) > looks like https://trac.webkit.org/changeset/239744/webkit > > caused > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webgpu%2Fvertex-buffer-triangle-strip.html > > To start failing continuously on High Sierra and up. Image diff shows it is > failing to render a green square. > > Diff: > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r239749%20(8737)/webgpu/ > vertex-buffer-triangle-strip-diffs.html Addressed in https://bugs.webkit.org/show_bug.cgi?id=193289.
Note You need to log in before you can comment on or make changes to this bug.