Summary: | [WebGPU] Update createRenderPipeline for WebGPUPipelineLayout | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Fan <justin_fan> | ||||||||
Component: | New Bugs | Assignee: | Justin Fan <justin_fan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, tsavell, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Justin Fan
2019-01-08 11:40:42 PST
Created attachment 358617 [details]
Patch
Created attachment 358618 [details]
Patch
Comment on attachment 358618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358618&action=review > Source/WebCore/platform/graphics/gpu/GPURenderPipelineDescriptor.h:47 > + // Needed, as aggregate initialization of derived structs is not supported until C++17. I don't think we need this comment. Created attachment 358626 [details]
Patch for landing
Comment on attachment 358626 [details] Patch for landing Clearing flags on attachment: 358626 Committed r239744: <https://trac.webkit.org/changeset/239744> All reviewed patches have been landed. Closing bug. looks like https://trac.webkit.org/changeset/239744/webkit caused http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgpu%2Fvertex-buffer-triangle-strip.html To start failing continuously on High Sierra and up. Image diff shows it is failing to render a green square. Diff: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r239749%20(8737)/webgpu/vertex-buffer-triangle-strip-diffs.html (In reply to Truitt Savell from comment #9) > looks like https://trac.webkit.org/changeset/239744/webkit > > caused > http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=webgpu%2Fvertex-buffer-triangle-strip.html > > To start failing continuously on High Sierra and up. Image diff shows it is > failing to render a green square. > > Diff: > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r239749%20(8737)/webgpu/ > vertex-buffer-triangle-strip-diffs.html Addressed in https://bugs.webkit.org/show_bug.cgi?id=193289. |