Bug 193244

Summary: Remove more use of NetworkProcess::singleton
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, beidson, bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Alex Christensen
Reported 2019-01-08 10:05:34 PST
Remove more use of NetworkProcess::singleton
Attachments
Patch (22.17 KB, patch)
2019-01-08 10:05 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (22.21 KB, patch)
2019-01-08 10:15 PST, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-08 10:05:48 PST
Created attachment 358606 [details] Patch
Alex Christensen
Comment 2 2019-01-08 10:15:47 PST
Created attachment 358610 [details] Patch
Brent Fulgham
Comment 3 2019-01-08 13:21:32 PST
Comment on attachment 358610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358610&action=review Looks good (I assume the ownership model is correct, just like my question in Bug 193243). r=me > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=193244 Radar :)
Alex Christensen
Comment 4 2019-01-08 13:24:37 PST
These should definitely keep the NetworkProcess alive, because the presence of these objects means we are starting new loads. http://trac.webkit.org/r239741
Radar WebKit Bug Importer
Comment 5 2019-01-08 13:25:29 PST
<rdar://problem/47126001>
Note You need to log in before you can comment on or make changes to this bug.