Bug 193237

Summary: Always call CompletionHandler in Cache::store
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, ews-watchlist, koivisto, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2019-01-08 08:15:39 PST
Always call CompletionHandler in Cache::store
Attachments
Patch (5.96 KB, patch)
2019-01-08 08:16 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.66 KB, patch)
2019-01-08 08:24 PST, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-08 08:16:52 PST
Created attachment 358592 [details] Patch
Alex Christensen
Comment 2 2019-01-08 08:24:52 PST
Created attachment 358593 [details] Patch
Alex Christensen
Comment 3 2019-01-08 08:43:27 PST
http://trac.webkit.org/r239725
Radar WebKit Bug Importer
Comment 4 2019-01-08 08:44:30 PST
<rdar://problem/47116303>
Truitt Savell
Comment 5 2019-01-08 13:49:48 PST
Changes in https://trac.webkit.org/changeset/239725/webkit Has caused http/tests/cache/disk-cache/disk-cache-disable.html To crash continuously. History: http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcache%2Fdisk-cache%2Fdisk-cache-disable.html reproduced with: run-webkit-tests --root testbuild-239725 http/tests/cache/disk-cache/disk-cache-disable.html --iterations 10 -f
Alex Christensen
Comment 6 2019-01-08 14:23:24 PST
http://trac.webkit.org/r239748 should fix that.
Alex Christensen
Comment 7 2019-01-08 17:28:52 PST
http://trac.webkit.org/r239759 reverted all my fixes and the problem I introduced today. Bots should be green. I unfortunately cannot run tests on my machine
Note You need to log in before you can comment on or make changes to this bug.