Bug 193234

Summary: [ews-build] unapply-patch step should not update source
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Proposed patch lforschler: review+

Aakash Jain
Reported 2019-01-08 07:10:58 PST
Currently unapply-patch step uses buildbot git methods with alwaysUseLatest=True. This cleans the working directory, but also updates the repository. We should not pull down new source changes.
Attachments
Proposed patch (1.79 KB, patch)
2019-01-08 07:12 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (1.76 KB, patch)
2019-01-08 07:25 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-08 07:12:54 PST
Created attachment 358586 [details] Proposed patch
EWS Watchlist
Comment 2 2019-01-08 07:16:10 PST
Attachment 358586 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:108: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Aakash Jain
Comment 3 2019-01-08 07:25:14 PST
Created attachment 358588 [details] Proposed patch
Aakash Jain
Comment 4 2019-01-09 06:30:02 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/25/builds/984
Lucas Forschler
Comment 5 2019-01-09 13:19:45 PST
Comment on attachment 358588 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=358588&action=review r=me with typo fix. > Tools/BuildSlaveSupport/ews-build/steps.py:111 > + description = ['clean-workring-directory running'] typo: working
Aakash Jain
Comment 6 2019-01-17 05:54:05 PST
Committed r240107: <https://trac.webkit.org/changeset/240107>
Radar WebKit Bug Importer
Comment 7 2019-01-17 05:55:27 PST
<rdar://problem/47349291>
Note You need to log in before you can comment on or make changes to this bug.