Summary: | Web Inspector: Audit: provide a way to get related Accessibility properties for a given node | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, hi, inspector-bugzilla-changes, jcraig, jdiggs, joepeck, samuel_white, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 190754, 193149 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Devin Rousso
2019-01-07 21:30:20 PST
Created attachment 358569 [details]
Patch
Will write tests later, once I have had a chance to look more into the other inspector accessibility tests.
Created attachment 358853 [details]
Patch
Comment on attachment 358853 [details]
Patch
r-, this one needs some kind of test (even if it is not exhaustive but at least tests the code path. Otherwise this seems good.
Created attachment 359775 [details]
Patch
Comment on attachment 359775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=359775&action=review r=me > LayoutTests/inspector/audit/run-accessibility.html:21 > + return JSON.stringify(mapped); You could prettyify this `JSON.stringify(mapped, null, 4)` which would make failure diffs easy to understand if a single property changed. Created attachment 359783 [details]
Patch
Comment on attachment 359783 [details] Patch Clearing flags on attachment: 359783 Committed r240309: <https://trac.webkit.org/changeset/240309> All reviewed patches have been landed. Closing bug. |