Bug 193218 – Web Inspector: Styles: clicking on property that soon to be discarded shouldn't start selection

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Created attachment 358538 [details]
[Video] Bug

Steps:
1. Add a new property "float"
2. Press Tab
3. Click on the white space on the right side of "float"

Expected:
The newly added property get discarded (because it has an empty value).

Actual:
The newly added property get discarded (because it has an empty value), but moving mouse cursor now selects properties.

[Radar WebKit Bug Importer]

<rdar://problem/47098303>

[Nikita Vasilyev]

Created attachment 358542 [details]
Patch

[Nikita Vasilyev]

Created attachment 358545 [details]
[Video] With patch applied

This fixes the bug and doesn't break anything else (that I know of :)).

[EWS Watchlist]

Comment on attachment 358542 [details]
Patch

Attachment 358542 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10665029

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 358562 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Nikita Vasilyev]

Comment on attachment 358542 [details]
Patch

Unrelated test failure.

[Devin Rousso]

Comment on attachment 358542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358542&action=review

r=me, nice refactor/fix

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:414
> +            this._stopSelection();

Rather than set `_isMousePressed` to `true` and then almost immediately reset it back to `false`, could we early return:

    if (!propertyElement || !propertyElement.parentNode)

[Nikita Vasilyev]

Comment on attachment 358542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358542&action=review

>> Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:414
>> +            this._stopSelection();
> 
> Rather than set `_isMousePressed` to `true` and then almost immediately reset it back to `false`, could we early return:
> 
>     if (!propertyElement || !propertyElement.parentNode)

`_isMousePressed` needs to be set to `true` before "blur" event triggered by `document.activeElement.blur()` or change of selection.

[WebKit Commit Bot]

Comment on attachment 358542 [details]
Patch

Clearing flags on attachment: 358542

Committed r239766: <https://trac.webkit.org/changeset/239766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.