Bug 193158 – Web Inspector: Audit: disable breakpoints when running Audit

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/47057083>

[Devin Rousso]

Created attachment 358367 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 358367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358367&action=review

r=me

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: Audit: disable breakpoints when running Audit

Should we include a test that a `debugger` statement doesn't cause a pause when the audit runs?

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1162
> +    _handleAuditManagerTestScheduled(event)
> +    {
> +        this._startDisablingBreakpointsTemporarily();
> +
> +        if (this.paused)
> +            this.resume();
> +    }
> +
> +    _handleAuditManagerTestCompleted(event)
> +    {
> +        this._stopDisablingBreakpointsTemporarily();
> +    }
> +

We may need start/stop to be counters / enums. Someone could technically attempt to start/stop a Timeline profile during audits and then the debugger would be enabled during any remaining audits.

[Devin Rousso]

Comment on attachment 358367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358367&action=review

>> Source/WebInspectorUI/ChangeLog:3
>> +        Web Inspector: Audit: disable breakpoints when running Audit
> 
> Should we include a test that a `debugger` statement doesn't cause a pause when the audit runs?

Ooooooo, I like it!

>> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:1162
>> +
> 
> We may need start/stop to be counters / enums. Someone could technically attempt to start/stop a Timeline profile during audits and then the debugger would be enabled during any remaining audits.

Another thing I noticed is that we dispatch `WI.AuditManager.Event.TestCompleted` whenever a test result is imported as well, meaning that if we started a Timeline recording and imported an audit result, we'd re-enable breakpoints.  That would need to change as well.

[Devin Rousso]

Created attachment 358391 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 358391 [details]
Patch

Clearing flags on attachment: 358391

Committed r239646: <https://trac.webkit.org/changeset/239646>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.