Summary: | A MediaTime timescale must never be zero | ||
---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> |
Component: | Media | Assignee: | Eric Carlson <eric.carlson> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, ews-watchlist, jer.noble, rniwa, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Local Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Eric Carlson
2019-01-04 13:32:08 PST
Created attachment 358385 [details]
Patch
Created attachment 358398 [details]
Patch
Comment on attachment 358398 [details] Patch Attachment 358398 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10635031 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html webaudio/silence-after-playback.html Created attachment 358406 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 358398 [details] Patch Attachment 358398 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/10635317 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html webaudio/silence-after-playback.html Created attachment 358407 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 358398 [details] Patch Attachment 358398 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10635436 New failing tests: imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html Created attachment 358417 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 358398 [details] Patch Attachment 358398 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10635518 New failing tests: http/wpt/css/css-animations/start-animation-001.html webaudio/silence-after-playback.html Created attachment 358420 [details]
Archive of layout-test-results from ews114 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 358442 [details]
Patch
Comment on attachment 358442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358442&action=review r=me with nit: > Source/WTF/wtf/MediaTime.cpp:90 > + if (value < 0) > + *this = negativeInfiniteTime(); > + else > + *this = positiveInfiniteTime(); Nit: in other places you use a ternary operator for this kind of thing. Created attachment 358510 [details]
Patch for landing
Comment on attachment 358510 [details] Patch for landing Clearing flags on attachment: 358510 Committed r239688: <https://trac.webkit.org/changeset/239688> All reviewed patches have been landed. Closing bug. |