| Summary: | Web Inspector: Add a Setting Toggle for Source Maps | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, joepeck, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2019-01-04 11:04:09 PST
Created attachment 358338 [details]
[PATCH] Proposed Fix
Comment on attachment 358338 [details]
[PATCH] Proposed Fix
r=me, should we add a `console.assert(WI.settings.sourceMapsEnabled.value)` inside `WI.SourceMap` somewhere, for sanity's sake? Do we want to do anything for the case where the user disables source maps after having already downloaded and shown them (e.g. in Resources)?
If I'm a naive user debugging JS stuff on a web site, how do I know that I need to enable or disable source maps? (In reply to Devin Rousso from comment #2) > Comment on attachment 358338 [details] > [PATCH] Proposed Fix > > r=me, should we add a `console.assert(WI.settings.sourceMapsEnabled.value)` > inside `WI.SourceMap` somewhere, for sanity's sake? Do we want to do > anything for the case where the user disables source maps after having > already downloaded and shown them (e.g. in Resources)? We should eventually do something where when the user toggles source maps it goes and hides / shows source maps stuff, but for now a reload is sufficient. (In reply to Simon Fraser (smfr) from comment #3) > If I'm a naive user debugging JS stuff on a web site, how do I know that I > need to enable or disable source maps? JavaScript developers should be familiar with the concept of source maps. If they are debugging their own content they should know, if they are debugging random content then its just something unfamiliar they would have to come across. The Web Inspector UI indicates SourceMaps uniquely in a few ways, which may help them recognize it is different. > (In reply to Simon Fraser (smfr) from comment #3)
> > If I'm a naive user debugging JS stuff on a web site, how do I know that I
> > need to enable or disable source maps?
>
> JavaScript developers should be familiar with the concept of source maps. If
> they are debugging their own content they should know, if they are debugging
> random content then its just something unfamiliar they would have to come
> across. The Web Inspector UI indicates SourceMaps uniquely in a few ways,
> which may help them recognize it is different.
In other words, learning about Source Maps is not much different than learning about some JS / CSS features you aren't familiar with.
Comment on attachment 358338 [details] [PATCH] Proposed Fix Clearing flags on attachment: 358338 Committed r239635: <https://trac.webkit.org/changeset/239635> All reviewed patches have been landed. Closing bug. |