Bug 193132 – Refactor 'platforms' table to contain group information.

• Component: New Bugs
• Status: RESOLVED FIXED

Refactor platform table to contain group infomation.

Created attachment 358307 [details]
Patch

Created attachment 358308 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 358308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358308&action=review

> Websites/perf.webkit.org/public/admin/platforms.php:99
> +    array_push($platform_group_options, array('platformgroup_id' => NULL, 'platformgroup_name' => '&ltNo Group&gt'));

Maybe just say "-"?

> Websites/perf.webkit.org/public/admin/platforms.php:103
> +        $id = $platform_row['platform_id'];

Call intval here just be safe.

> Websites/perf.webkit.org/public/v3/models/analysis-task.js:180
> +        const fetchingMeasurementSetForOtherPlatformInSameGroupPromises = this._commitSetForOtherPlatformsInSameGroup();

This is awfully long variable name. Also, this isn't fetching measurement set so we probably shouldn't call it that.
How about commitSetsInSamePlatformGroupPromise?

> Websites/perf.webkit.org/public/v3/models/analysis-task.js:198
> +    _commitSetForOtherPlatformsInSameGroup()

"SameGroup" is a bit ambiguous here because there is also test group.
I think I'd prefer call this _commitSetsInSamePlatformGroup.

This should have been landed long time ago.
Rebased against latest main branch and verified all unit tests are still passing.
Landed in r269083.