Bug 193106

Summary:

UI process side scrollbars for UI side compositing on Mac

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cmarcelo, commit-queue, ews-watchlist, fred.wang, ggaren, jamesr, luiz, rniwa, simon.fraser, thorton, tonikitoo, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
wip	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
patch	none
patch	none
patch	none
patch	none
patch	none

Antti Koivisto

Reported 2019-01-03 08:27:13 PST

Scrollbars should live in the UI process.

Attachments
wip (55.56 KB, patch) 2019-01-03 11:32 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.23 MB, application/zip) 2019-01-03 12:58 PST, EWS Watchlist	no flags	Details
patch (72.41 KB, patch) 2019-01-04 09:54 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.04 MB, application/zip) 2019-01-04 11:15 PST, EWS Watchlist	no flags	Details
patch (73.11 KB, patch) 2019-01-04 11:35 PST, Antti Koivisto	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.94 MB, application/zip) 2019-01-04 13:04 PST, EWS Watchlist	no flags	Details
patch (73.64 KB, patch) 2019-01-05 03:46 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (108.04 KB, patch) 2019-01-05 04:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (74.68 KB, patch) 2019-01-05 04:46 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (75.86 KB, patch) 2019-01-07 05:09 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (75.64 KB, patch) 2019-01-07 06:35 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2019-01-03 11:32:02 PST

Created attachment 358266 [details] wip

EWS Watchlist

Comment 2 2019-01-03 11:37:12 PST

Attachment 358266 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:235: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2019-01-03 12:58:07 PST

Comment on attachment 358266 [details] wip Attachment 358266 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10618816 New failing tests: svg/dom/SVGViewSpec.html

EWS Watchlist

Comment 4 2019-01-03 12:58:09 PST

Created attachment 358272 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Frédéric Wang (:fredw)

Comment 5 2019-01-04 07:26:37 PST

Comment on attachment 358266 [details] wip Just a quick comment: In ScrollingTreeScrollingNode/ScrollingStateScrollingNode we use the order horizontal,vertical (i.e. X and Y) when storing/dumping/setting/getting the parameters. In this WIP patch you are using the order vertical,horizontal.

Antti Koivisto

Comment 6 2019-01-04 08:46:12 PST

(In reply to Frédéric Wang (:fredw) from comment #5) > Just a quick comment: In > ScrollingTreeScrollingNode/ScrollingStateScrollingNode we use the order > horizontal,vertical (i.e. X and Y) when storing/dumping/setting/getting the > parameters. In this WIP patch you are using the order vertical,horizontal. It is not very consistent, especially with scrollbars. ScrollingTreeFrameScrollingNodeMac for example uses vertical/horizontal order. The argument would be that vertical bars are way more common and so important than horizontal.

Antti Koivisto

Comment 7 2019-01-04 09:54:22 PST

Created attachment 358325 [details] patch

EWS Watchlist

Comment 8 2019-01-04 09:56:15 PST

Attachment 358325 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:213: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 9 2019-01-04 11:15:25 PST

Comment on attachment 358325 [details] patch Attachment 358325 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10629523 New failing tests: svg/dom/SVGViewSpec.html

EWS Watchlist

Comment 10 2019-01-04 11:15:28 PST

Created attachment 358339 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 11 2019-01-04 11:35:00 PST

Created attachment 358344 [details] patch

EWS Watchlist

Comment 12 2019-01-04 11:37:51 PST

Attachment 358344 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:213: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 13 2019-01-04 13:04:40 PST

Comment on attachment 358344 [details] patch Attachment 358344 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10631241 New failing tests: svg/dom/SVGViewSpec.html

EWS Watchlist

Comment 14 2019-01-04 13:04:42 PST

Created attachment 358353 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Antti Koivisto

Comment 15 2019-01-05 03:46:13 PST

Created attachment 358433 [details] patch

EWS Watchlist

Comment 16 2019-01-05 03:48:10 PST

Attachment 358433 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:213: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 17 2019-01-05 04:22:20 PST

Created attachment 358437 [details] patch

EWS Watchlist

Comment 18 2019-01-05 04:25:10 PST

Attachment 358437 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:213: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 19 2019-01-05 04:46:23 PST

Created attachment 358438 [details] patch

EWS Watchlist

Comment 20 2019-01-05 04:47:58 PST

Attachment 358438 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:213: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 21 2019-01-07 05:09:40 PST

Created attachment 358492 [details] patch

EWS Watchlist

Comment 22 2019-01-07 05:11:24 PST

Attachment 358492 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:212: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 23 2019-01-07 06:35:21 PST

Created attachment 358493 [details] patch

EWS Watchlist

Comment 24 2019-01-07 06:37:07 PST

Attachment 358493 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollerMac.mm:198: Misplaced OS version check. Please use a named macro in wtf/Platform.h or wtf/FeatureDefines.h. [build/version_check] [5] Total errors found: 1 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 25 2019-01-07 11:40:16 PST

Comment on attachment 358493 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=358493&action=review > Source/WebKit/UIProcess/mac/PageClientImplMac.mm:97 > +@interface NSWindow (WebNSWindowLayerHostingDetails) Could also just drop the name entirely. > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:94 > +@interface NSWindow (WebNSWindowFullScreenDetails) Could also just drop the name entirely.

WebKit Commit Bot

Comment 26 2019-01-07 12:11:05 PST

Comment on attachment 358493 [details] patch Clearing flags on attachment: 358493 Committed r239689: <https://trac.webkit.org/changeset/239689>

WebKit Commit Bot

Comment 27 2019-01-07 12:11:07 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 28 2019-01-07 12:12:37 PST

<rdar://problem/47092469>

Note You need to log in before you can comment on or make changes to this bug.