Bug 193105

Summary: Progress towards fixing Mac CMake build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CMakeAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, ews-watchlist
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
don.olmstead: review+
patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews115 for mac-sierra none

Alex Christensen
Reported 2019-01-03 07:46:19 PST
Progress towards fixing Mac CMake build
Attachments
Patch (16.34 KB, patch)
2019-01-03 07:48 PST, Alex Christensen 		don.olmstead: review+
DetailsFormatted DiffDiff
patch (13.81 KB, patch)
2019-01-04 13:43 PST, Alex Christensen 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews115 for mac-sierra (2.16 MB, application/zip)
2019-01-04 16:22 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-01-03 07:48:28 PST
Created attachment 358254 [details] Patch
Don Olmstead
Comment 2 2019-01-03 16:22:59 PST
Comment on attachment 358254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358254&action=review r=me contingent on the build passing :) > Source/WebCore/Modules/indexeddb/shared/IDBError.h:31 > -#include "DOMException.h" > #include "ExceptionCode.h" > +#include <WebCore/DOMException.h> This shouldn't have been changed and looks to be part of the build breakage. > Source/WebCore/platform/graphics/gpu/GPURenderPassEncoder.h:31 > +#include "GPURenderPipeline.h" GPURenderPipeline is forward declared in this file so either remove this or remove the declaration.
Alex Christensen
Comment 3 2019-01-04 13:43:08 PST
Created attachment 358360 [details] patch
EWS Watchlist
Comment 4 2019-01-04 16:22:23 PST
Comment on attachment 358360 [details] patch Attachment 358360 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/10633448 New failing tests: http/wpt/css/css-animations/start-animation-001.html
EWS Watchlist
Comment 5 2019-01-04 16:22:24 PST
Created attachment 358393 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Alex Christensen
Comment 6 2019-01-04 17:12:40 PST
https://trac.webkit.org/changeset/239648/webkit
Note You need to log in before you can comment on or make changes to this bug.