Bug 193104

Summary: [GLIB] WebDriver: browser close not correctly detected on session close in some cases
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, bugs-noreply, ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2019-01-03 07:25:44 PST 
This happens when the dbus connection is closed right before the response to SendMessageToBackend message is going to be sent. In that case, g_dbus_connection_call async ready handler generates an error before the close signal is emitted. Then the close commands try to handle the error checking if SessionHost::isConnected(), but it still returns true, because the browser is still still alive, but the dbus connection has been closed.
Comment 1 Carlos Garcia Campos 2019-01-03 07:28:16 PST 
Created attachment 358252 [details]
Patch
Comment 2 EWS Watchlist 2019-01-03 07:30:05 PST 
Attachment 358252 [details] did not pass style-queue:


ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:112:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2019-01-03 07:33:09 PST 
Created attachment 358253 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-01-04 03:34:08 PST 
Committed r239606: <https://trac.webkit.org/changeset/239606>
Comment 5 Radar WebKit Bug Importer 2019-01-04 03:41:48 PST 
<rdar://problem/47045793>