Bug 193069

Summary: [WPE][GTK] Add new WPE and JSC API directories to API watchlist
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: NEW    
Severity: Normal CC: bugs-noreply, cgarcia, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2019-01-01 17:46:55 PST
Add new WPE and JSC API directories to API watchlist
Attachments
Patch (2.60 KB, patch)
2019-01-01 17:47 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2019-01-01 17:47:56 PST
Created attachment 358178 [details] Patch
Carlos Garcia Campos
Comment 2 2019-01-02 23:40:21 PST
Comment on attachment 358178 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358178&action=review > Tools/Scripts/webkitpy/common/config/watchlist:72 > "GtkWebKit2PublicAPI": { I would change this name too. GLibPublicAPI for example, or GTKWPEPublicAPI. But Gtk and WebKit2 are no longer true. > Tools/Scripts/webkitpy/common/config/watchlist:443 > + "GtkWebKit2PublicAPI": [ "Thanks for the patch. If this patch contains new GTK or WPE API " JSC is not GTK nor WPE API. > Tools/Scripts/webkitpy/common/config/watchlist:445 > "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ], This URL looks weird too now. We should probably rename it and update it to reflect WPE and JSC if we really want to use the same guidelines.
Note You need to log in before you can comment on or make changes to this bug.